Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve some tests that have been unreliable #767

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Conversation

mflatt
Copy link
Contributor

@mflatt mflatt commented Nov 23, 2023

A compute-size-increments test has been a long-time problem. It turns out that it was failing randomly due to a random list of symbols stashed in a thread parameter by an earlier test; sometimes, one of those symbols can reach a lot of data. The solution here is to not count data reachable from thread parameters.

A cost-center-time test has been failing on very slow machines. As a timing test, it's inherently unreliable, but turning up the limit should make failures rare enough without making the test useless.

A `compute-size-increments` test has been a long-time problem. It
turns out that it was failing randomly due to a random list of symbols
stashed in a thread parameter by an earlier test; sometimes, one of
those symbols can reach a lot of data. The solution here is to
not count data reachable from thread parameters.

A `cost-center-time` test has been failing on very slow machines. As a
timing test, it's inherently unreliable, but turning up the limit
should make failures rare enough without making the test useless.
@mflatt mflatt merged commit 612b7ad into cisco:main Nov 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants